Skip to content

Just testing DI rework #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
woozer wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Just testing DI rework #1

woozer wants to merge 1 commit into from

Conversation

@woozer
Copy link
Owner

@woozer woozer commented Jan 26, 2026 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

Release Notes

Refactor

  • Improved app architecture by implementing dependency injection patterns throughout the application for better maintainability and separation of concerns.
  • Refactored supporters dialog to use ViewModel-driven state management for more reliable data handling and lifecycle awareness.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 26, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

The changes migrate Supabase integration from a global initialization pattern in the main app class to a dependency injection approach using Dagger/Hilt. A singleton Supabase provider module is introduced, with data access logic extracted into a repository layer, and UI state management transitioned to ViewModel-backed components.

Changes

Cohort / File(s) Summary
Dependency Injection Setup
app/src/main/java/app/gamenative/PluviaApp.kt, app/src/main/java/app/gamenative/di/SupabaseModule.kt		 Removed global Supabase client and initialization from PluviaApp (−45 lines). Introduced new SupabaseModule providing singleton SupabaseClient with HTTP timeout configuration and Postgrest plugin setup (+48 lines).
Repository Layer
app/src/main/java/app/gamenative/repository/GameFeedbackRepository.kt		 Added SupabaseRepository class wrapping SupabaseClient for game feedback submission and supporter fetching, with null-safety guards. Injected as dependency via Hilt (+35 lines).
UI ViewModel Layer
app/src/main/java/app/gamenative/ui/model/MainViewModel.kt, app/src/main/java/app/gamenative/ui/model/SupportersViewModel.kt		 Injected SupabaseRepository into MainViewModel with new submitGameFeedback() delegation method. Introduced new SupportersViewModel managing supporters list and loading state via StateFlow with load optimization guard (+58 lines).
UI Components
app/src/main/java/app/gamenative/ui/PluviaMain.kt, app/src/main/java/app/gamenative/ui/component/dialog/SupportersDialog.kt		 Updated PluviaMain to call viewModel.submitGameFeedback() instead of direct utility (−3 lines). Migrated SupportersDialog from manual data loading to ViewModel-driven state via collectAsStateWithLifecycle and LaunchedEffect (+9 lines).

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~50 minutes

Poem

🐰 From globals to singles, a journey so neat,
Hilt weaves threads where dependencies meet.
Repositories rise, ViewModels align,
The architecture refactors—now structured, refined! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'Just testing DI rework' is vague and generic, using non-descriptive terms that don't convey meaningful information about what was actually changed in the pull request. Replace with a more specific title that describes the main change, such as 'Migrate Supabase initialization to Hilt DI module' or 'Refactor Supabase client to use dependency injection'.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@woozer